Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fedora spec file and basic packit configuration #96

Merged
merged 3 commits into from
Dec 21, 2024

Conversation

pemensik
Copy link
Member

Initialize basic spec and packit building.

Should be used together with packit for creating spec versions.
Recreate ./configure even if it were shipped from sources. It is not in
sources now anyway.
@pemensik pemensik added the CI label Dec 21, 2024
@pemensik pemensik self-assigned this Dec 21, 2024
@pemensik pemensik merged commit 3709e20 into avahi:master Dec 21, 2024
16 checks passed
@pemensik pemensik deleted the fedora branch December 21, 2024 20:28
@evverx
Copy link
Member

evverx commented Dec 21, 2024

@pemensik can you reuse the spec file from the Fedora package and edit it with sed in .packit.yml if necessary (by analogy with what avahi, dbus-broker and so on do) and remove pkg/rpm-fedora/nss-mdns.spec? There is no need to keep and maintain downstream things upstream.

@pemensik
Copy link
Member Author

No, I think upstream included copy does not hurt and it will make it simpler to create the package via packit or help any rpm distribution to start their own package. I made it simple enough to not require further changes on every update. Nothing packit could not handle at least. I think one rpm template does not hurt. Especially when we have to remove things from fedora package spec, it is no longer simple. But that is hidden in .packit.dev file instead of visible file.

I prefer it the way I used.

@evverx
Copy link
Member

evverx commented Dec 21, 2024

upstream included copy does not hurt

Dunno. It kind of opens that door where downstream stuff ends up being offloaded onto upstream projects. That's probably how the avahi repository ended up with a bunch of downstream-specific scripts nobody actually maintains and tests downstream because it's probably assumed that they are maintained upstream (which they aren't of course).

help any rpm distribution to start their own package

I'm not sure why it would be necessary but by this logic it would make sense to cover deb-based distros as well.

Then again it's not something that should be kept upstream.

(FWIW since it's upstream now it should come with the SPDX IDs and stuff like that)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants